[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [AUCTeX-devel] fancyhdr.el + fancynum.el
From: |
Mads Jensen |
Subject: |
Re: [AUCTeX-devel] fancyhdr.el + fancynum.el |
Date: |
Thu, 14 Feb 2013 00:17:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 |
On 2013-02-13 20:34, Tassilo Horn wrote:
> I've committed fancynum.el.
Thank you :-)
> But there are some nitpicks wrt. fancyhdr.el. Please fix those and send
> an improved patch.
>
> - `fancyhdr-fancy-positions' is used only in one position, so no need to
> have a defvar for it. Also, if the variable was needed, it should
> have a name matching the conventions, e.g.,
> `LaTeX-fancyhdr-fancy-positions'.
Removed, and put inside the function with a suitable comment similar to
the one for the variable.
> - Now that the parser supports pagestyles, you should add the fancy and
> fancyplain pagestyles provided by fancyhdr. See
> `LaTeX-add-pagestyles'.
Yep, plainly forgot :-( Thanks for reminding me.
> - `TeX-arg-fancyhdr-position': The first line of the docstring should be
> one complete sentence. I suggest "Promt for a fancyhdr position."
> You should also document all arguments. Have a look at the other
> TeX-arg-* functions.
Documented as requested.
As requested, a patch for Makefile.in is also provided.
2013-02-14 Mads Jensen <address@hidden>
* Makefile.in (STYLESRC): Activate new style fancyhdr.el.
* style/fancyhdr.el: New style.
--
Med Venlig Hilsen / Kind Regards,
Mads Jensen
Rubinsteinsvej 31,st.th
DK-2450 Kbh. SV
Denmark
+45 6168 8518
My brain is my second favorite organ.
-- Woody Allen
Makefile.in.patch
Description: Text Data
fancyhdr.el
Description: Text Data
signature.asc
Description: OpenPGP digital signature