Re: [AUCTeX-devel] [PATCH] Various patches

[Mosè Giordano]

Hi Arash,

2015-08-22 12:13 GMT+02:00 Arash Esbati <address@hidden>:
> As always, any comments welcome.

I reviewed your patches, they're overall fine, as usual, I have only a
minor concern about captionbox: for the label you could simply call

    (TeX-insert-macro "label")

which will do the-right-thing.  In this way `TeX-read-label' isn't
needed anymore.!  So,

    (TeX-argument-insert heading optional)

can be replaced by (didn't actually tested, but this or something
close to this should do the trick)

    (insert TeX-arg-opening-brace caption)
    (if star (TeX-insert-macro "label"))
    (insert TeX-arg-closing-brace)

Just remember to let-bind the opening/closing brace depending on the
value of `optional'.

Sorry, I didn't look closely to the patch in your previous email.

Bye,
Mosè