Re: [patch #7612] AX_PROG_DOXYGEN: cleaned up use of AM_CONDITIONAL

[Maarten Bosmans]

In general, solving this by using AS_IF is a nice way.
But in this case moving the AM_CONDITIONAL a bit up is OK too.

Maarten

2011/9/5 anonymous <address@hidden>:
> URL:
>  <http://savannah.gnu.org/patch/?7612>
>
>                 Summary: AX_PROG_DOXYGEN: cleaned up use of AM_CONDITIONAL
>                 Project: GNU Autoconf Archive
>            Submitted by: None
>            Submitted on: Mon 05 Sep 2011 08:07:10 AM UTC
>                Priority: 4
>                  Status: None
>             Assigned to: None
>        Originator Email: address@hidden
>             Open/Closed: Open
>         Discussion Lock: Any
>
>    _______________________________________________________
>
> Details:
>
> Right now the AX_PROG_DOXYGEN macro uses AM_CONDITIONAL inside of a shell if
> statement, which is warned against in the automake manual.
>
> http://www.gnu.org/s/hello/manual/automake/Usage-of-Conditionals.html
>
> In this particular case, using AM_COND_IF(DX_COND_doc, ...) always acted as if
> DX_COND_doc was false, even if it was true.
>
> The attached git patch fixes this by moving the AM_CONDITIONAL macros outside
> of shell flow control.
>
>
>
>    _______________________________________________________
>
> File Attachments:
>
>
> -------------------------------------------------------
> Date: Mon 05 Sep 2011 08:07:10 AM UTC  Name:
> 0001-AX_PROG_DOXYGEN-cleaned-up-use-of-AM_CONDITIONAL.patch  Size: 2kB   By:
> None
>
> <http://savannah.gnu.org/patch/download.php?file_id=23939>
>
>    _______________________________________________________
>
> Reply to this item at:
>
>  <http://savannah.gnu.org/patch/?7612>
>
> _______________________________________________
>  Message sent via/by Savannah
>  http://savannah.gnu.org/
>
>
>