autoconf-archive-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #7673] AX_BOOST_PYTHON should use quotes when setting CPPFLAGS


From: anonymous
Subject: [patch #7673] AX_BOOST_PYTHON should use quotes when setting CPPFLAGS
Date: Mon, 21 Nov 2011 16:06:19 +0000
User-agent: Mozilla/5.0 (Ubuntu; X11; Linux i686; rv:9.0) Gecko/20100101 Firefox/9.0

URL:
  <http://savannah.gnu.org/patch/?7673>

                 Summary: AX_BOOST_PYTHON should use quotes when setting
CPPFLAGS
                 Project: GNU Autoconf Archive
            Submitted by: None
            Submitted on: Mon 21 Nov 2011 04:06:16 PM UTC
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Hello!  AX_BOOST_PYTHON does not use quotes when setting CPPFLAGS, which can
cause problems if CPPFLAGS is already defined to something.  For example:

1) Imagine CPPFLAGS starts as "-DTEST=1 -DTEST=2"
2) "CPPFLAGS_SAVE=$CPPFLAGS" will expand to "CPPFLAGS_SAVE=-DTEST=1 -DTEST=2"
which will try to run the program "-DTEST=2" with a temporary CPPFLAG_SAVE
environment variable.

1) Imagine CPPFLAGS starts as "-DTEST=1"
2) You'll get past the previous problem because CPPFLAGS is only one word.
3) But "CPPFLAGS=-I$PYTHON_INCLUDE_DIR $CPPFLAGS" will expand to something
like "CPPFLAGS=-I/usr/include/python2.7 -DTEST=1" and you hit the same issue
again.  The program "-DTEST=1" will not be found.

The attached patch fixes AX_BOOST_PYTHON for me.  A quick grep showed that
some other macros might be affected too, so you might want to do a general
check.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 21 Nov 2011 04:06:16 PM UTC  Name: ax_boost_python.diff  Size: 848B 
 By: None

<http://savannah.gnu.org/patch/download.php?file_id=24414>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7673>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]