|
From: | Michael Petch |
Subject: | [patch #8084] av_ext's AVX check doesn't determine if OS actually supports AVX |
Date: | Mon, 24 Jun 2013 16:52:53 +0000 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.52 Safari/537.36 |
Follow-up Comment #4, patch #8084 (project autoconf-archive): I am supplying an updated patch for my original(ax_ext.m4.patch2) . The rationale for this update isn't because the original logic was incorrect, it unfortunately had side effects on some OS's when the xgetbv function wasn't a legal instruction on the processor. In particular when built for MS Windows (Using MinGW) executing xgetbv on an non-AVX enabled processor ended up being trapped by the OS and a modal dialog box being presented to the user. Of course for a make process that is bad. The macro was modified to only execute xgetbv if we detect an AVX enabled CPU. The macro was also was modified to make sure the autoconf output didn't get nested. I also cleaned up some of the English in the output. (file #28399) _______________________________________________________ Additional Item Attachment: File name: ax_ext.m4.patch2 Size:5 KB _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?8084> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |