[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: four patches
From: |
Stepan Kasal |
Subject: |
Re: four patches |
Date: |
Fri, 15 Jul 2005 12:20:50 +0200 |
User-agent: |
Mutt/1.4.1i |
Hello Ralf,
On Fri, Jul 15, 2005 at 08:04:56AM +0200, Ralf Corsepius wrote:
> On Thu, 2005-07-07 at 13:30 +0200, Stepan Kasal wrote:
> > autoconf-20050629-canon.patch
>
> What is the rationale for replacing the
> 'test -z' with 'test "x$pat" = x' ?
>
> IMO, you are trying to fix non-bugs, here, because even info autoconf
> states:
> ...
> Contrary to a common belief, `test -n STRING' and `test -z STRING'
> *are* portable.
> ...
and that very paragraph explains that problem might arise if the string
looks like an operator.
In my patch, the variables were build_alias, host_alias, target_alias.
All of these three are given by the user on the command line, so they can
possibly contain any string.
Hope this explains it,
Stepan