[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Properly handle funny file names for headers in config.st
From: |
Benoit Sigoure |
Subject: |
Re: [PATCH v2] Properly handle funny file names for headers in config.status. |
Date: |
Tue, 18 Dec 2007 12:00:40 +0100 |
On Dec 18, 2007, at 9:46 AM, Benoit Sigoure wrote:
On Dec 18, 2007, at 8:09 AM, Benoit Sigoure wrote:
+esac
+
# Neutralize VPATH when `$srcdir' = `.'.
+# Run the same test a 2nd time to see that config.status does
not recreate
+# the header (regression test)
+AT_CHECK([./config.status "--header=$file:$file.in"],
+ [0], [config.status: creating file with funny \ ' \' $ & #!
*? name
+config.status: file with funny \ ' \' $ & #!*? name is unchanged
Unrelated to what you are fixing, but this test also needs
factoring into
w32-safe characters, so we might as well do it now; see
http://lists.gnu.org/archive/html/autoconf-patches/2007-12/
msg00044.html
OK, let's do it in a separate commit.
I an attempt to test my patch on a Windows XP machine running
latest Cygwin packages, I stumbled on the following oddity during:
$ autoreconf -vi && ./configure -C && make check TESTSUITEFLAGS='-d
5 28 119'
[...]
local.at:19: error: Autoconf version 2.57 or higher is required
local.at:19: the top level
autom4te: /usr/bin/m4 failed with exit status: 63
make[2]: *** [testsuite] Error 63
make[2]: Leaving directory `/tmp/ac/tests'
$ for i in autoconf automake libtool m4; do $i --version | sed q; done
autoconf (GNU Autoconf) 2.61
automake (GNU automake) 1.10
ltmain.sh (GNU libtool) 1.5.23a (1.1220.2.412 2006/10/13 14:13:30)
m4 (GNU M4) 1.4.10
Here another oddity. I get a spurious failure of test 119:
++ chmod a-w .
++ set +x
./torture.at:234: ./config.status var-file </dev/null
++ ./config.status var-file
stderr:
stdout:
config.status: creating var-file
./torture.at:234: exit code was 0, expected 1
WTF?!
Look, the current directory is read-only, and config.status can
create the `var-file'! I can't even create it myself... What the
hell is going on?!
.../testsuite.dir/119 $ ls -la
total 134K
dr-x--x--x+ 3 build Aucun 0 Dec 18 11:53 ./
drwx--x--x+ 5 build Aucun 0 Dec 18 11:50 ../
drwx--x--x+ 2 build Aucun 0 Dec 18 11:50 autom4te.cache/
-rw------- 1 build Aucun 4.3K Dec 18 11:53 config.log
-rwx--x--x 1 build Aucun 28K Dec 18 11:51 config.status*
-rwx--x--x 1 build Aucun 84K Dec 18 11:50 configure*
-rw------- 1 build Aucun 724 Dec 18 11:50 configure.ac
-rw------- 1 build Aucun 3 Dec 18 11:51 input
-rw------- 1 build Aucun 8.0K Dec 18 11:51 testsuite.log
-rw------- 1 build Aucun 3 Dec 18 11:53 var-file
.../testsuite.dir/119 $ rm var-file
.../testsuite.dir/119 $ ls -la
total 133K
dr-x--x--x+ 3 build Aucun 0 Dec 18 12:00 ./
drwx--x--x+ 5 build Aucun 0 Dec 18 11:50 ../
drwx--x--x+ 2 build Aucun 0 Dec 18 11:50 autom4te.cache/
-rw------- 1 build Aucun 4.3K Dec 18 11:53 config.log
-rwx--x--x 1 build Aucun 28K Dec 18 11:51 config.status*
-rwx--x--x 1 build Aucun 84K Dec 18 11:50 configure*
-rw------- 1 build Aucun 724 Dec 18 11:50 configure.ac
-rw------- 1 build Aucun 3 Dec 18 11:51 input
-rw------- 1 build Aucun 8.0K Dec 18 11:51 testsuite.log
.../testsuite.dir/119 $ ./config.status var-file </dev/null
config.status: creating var-file
.../testsuite.dir/119 $ ls -la
total 134K
dr-x--x--x+ 3 build Aucun 0 Dec 18 12:01 ./
drwx--x--x+ 5 build Aucun 0 Dec 18 11:50 ../
drwx--x--x+ 2 build Aucun 0 Dec 18 11:50 autom4te.cache/
-rw------- 1 build Aucun 4.6K Dec 18 12:01 config.log
-rwx--x--x 1 build Aucun 28K Dec 18 11:51 config.status*
-rwx--x--x 1 build Aucun 84K Dec 18 11:50 configure*
-rw------- 1 build Aucun 724 Dec 18 11:50 configure.ac
-rw------- 1 build Aucun 3 Dec 18 11:51 input
-rw------- 1 build Aucun 8.0K Dec 18 11:51 testsuite.log
-rw------- 1 build Aucun 3 Dec 18 12:01 var-file
.../testsuite.dir/119 $ rm var-file
.../testsuite.dir/119 $ ls -la
total 133K
dr-x--x--x+ 3 build Aucun 0 Dec 18 12:01 ./
drwx--x--x+ 5 build Aucun 0 Dec 18 11:50 ../
drwx--x--x+ 2 build Aucun 0 Dec 18 11:50 autom4te.cache/
-rw------- 1 build Aucun 4.6K Dec 18 12:01 config.log
-rwx--x--x 1 build Aucun 28K Dec 18 11:51 config.status*
-rwx--x--x 1 build Aucun 84K Dec 18 11:50 configure*
-rw------- 1 build Aucun 724 Dec 18 11:50 configure.ac
-rw------- 1 build Aucun 3 Dec 18 11:51 input
-rw------- 1 build Aucun 8.0K Dec 18 11:51 testsuite.log
.../testsuite.dir/119 $ touch var-file
touch: cannot touch `var-file': Permission denied
.../testsuite.dir/119 $ : >var-file
zsh: permission denied: var-file
.../testsuite.dir/119 $ ls -la
total 133K
dr-x--x--x+ 3 build Aucun 0 Dec 18 12:01 ./
drwx--x--x+ 5 build Aucun 0 Dec 18 11:50 ../
drwx--x--x+ 2 build Aucun 0 Dec 18 11:50 autom4te.cache/
-rw------- 1 build Aucun 4.6K Dec 18 12:01 config.log
-rwx--x--x 1 build Aucun 28K Dec 18 11:51 config.status*
-rwx--x--x 1 build Aucun 84K Dec 18 11:50 configure*
-rw------- 1 build Aucun 724 Dec 18 11:50 configure.ac
-rw------- 1 build Aucun 3 Dec 18 11:51 input
-rw------- 1 build Aucun 8.0K Dec 18 11:51 testsuite.log
Woe32 :(
--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory