Re: autotest/package.m4 question [PATCH]

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 10/16/2008 7:43 AM:
> Here's what I'm considering checking in; I'd like some feedback to make
> sure I'm not missing anything.  For that matter, since the 'missing'
> script supports autom4te, should we update the example to use missing, so
> that if a user touches testsuite.at but lacks Autoconf, they get nicer
> behavior than a failed make run?

I've modified the patch to mention missing, as well as provide a sample
definition of AUTOM4TE.  Here's what I squashed on top; the overall patch
is now committed.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj/C9EACgkQ84KuGfSFAYB82wCfRY/8tLJeDe7BEOxEbs8YJ03I
jLYAnj85nY4t5hQqZIbK6dM7ZkckFys0
=c7R3
-----END PGP SIGNATURE-----

diff --git a/ChangeLog b/ChangeLog
index 151dff8..5007d8c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,9 +1,9 @@
-2008-10-16  Eric Blake  <address@hidden>
+2008-10-21  Eric Blake  <address@hidden>
 
        Improve wording related to automake and autotest.
        * doc/autoconf.texi (Making testsuite Scripts): Clarify wording in
        relation to automake.  Mention dependency on package.m4.
-       Consolidate examples.
+       Consolidate examples.  Define AUTOM4TE.
        * THANKS: Update.
        Reported by William Pursell.
 
diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index 0988390..71f507f 100644
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -21638,11 +21638,16 @@ Making testsuite Scripts
 $(srcdir)/package.m4: $(top_srcdir)/configure.ac
         :;@{ \
           echo '# Signature of the current package.' && \
-          echo 'm4_define([AT_PACKAGE_NAME],      [@@PACKAGE_NAME@@])' && \
-          echo 'm4_define([AT_PACKAGE_TARNAME],   [@@PACKAGE_TARNAME@@])' && \
-          echo 'm4_define([AT_PACKAGE_VERSION],   [@@PACKAGE_VERSION@@])' && \
-          echo 'm4_define([AT_PACKAGE_STRING],    [@@PACKAGE_STRING@@])' && \
-          echo 'm4_define([AT_PACKAGE_BUGREPORT], [@@PACKAGE_BUGREPORT@@])'; \
+          echo 'm4_define([AT_PACKAGE_NAME],' && \
+          echo '  [@@PACKAGE_NAME@@])' && \
+          echo 'm4_define([AT_PACKAGE_TARNAME],' && \
+          echo '  [@@PACKAGE_TARNAME@@])' && \
+          echo 'm4_define([AT_PACKAGE_VERSION],' && \
+          echo '  [@@PACKAGE_VERSION@@])' && \
+          echo 'm4_define([AT_PACKAGE_STRING],' && \
+          echo '  [@@PACKAGE_STRING@@])' && \
+          echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \
+          echo '  [@@PACKAGE_BUGREPORT@@])'; \
         @} >'$(srcdir)/package.m4'
 
 EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) atlocal.in
@@ -21659,6 +21664,7 @@ Making testsuite Scripts
         test ! -f '$(TESTSUITE)' || \
          $(SHELL) '$(TESTSUITE)' --clean
 
+AUTOM4TE = $(SHELL) $(srcdir)/build-aux/missing --run autom4te
 AUTOTEST = $(AUTOM4TE) --language=autotest
 $(TESTSUITE): $(srcdir)/testsuite.at
         $(AUTOTEST) -I '$(srcdir)' -o $@@.tmp $@@.at
@@ -21667,14 +21673,16 @@ Making testsuite Scripts
 
 Note that the built testsuite is distributed; this is necessary because
 users might not have Autoconf installed, and thus would not be able to
-rebuild it.
+rebuild it.  Likewise, the use of @file{missing} provides the user with
+a nicer error message if they modify a source file to the testsuite, and
+accidentally trigger the rebuild rules.
 
 You might want to list explicitly the dependencies, i.e., the list of
 the files @file{testsuite.at} includes.
 
 If you don't use Automake, you should include the above example in
address@hidden/Makefile.in}, along with additional lines inspired from the
-following:
address@hidden/@/Makefile.in}, along with additional lines inspired from
+the following:
 
 @example
 subdir = tests
@@ -21689,7 +21697,9 @@ Making testsuite Scripts
 @end example
 
 @noindent
-and manage to have @code{$(EXTRA_DIST)} distributed.
+and manage to have @code{$(EXTRA_DIST)} distributed.  You will also want
+to distribute the file @file{build-aux/@/missing} from the Automake
+project; a copy of this file resides in the Autoconf source.
 
 With all this in place, and if you have not initialized @samp{TESTSUITEFLAGS}
 within your makefile, you can fine-tune test suite execution with this