[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coverage and doc fixes for AC_LANG_SOURCE and AC_LANG_PROGRAM.
|
From: |
Eric Blake |
|
Subject: |
Re: Coverage and doc fixes for AC_LANG_SOURCE and AC_LANG_PROGRAM. |
|
Date: |
Mon, 07 Jun 2010 19:31:08 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.4 |
On 06/06/2010 05:56 AM, Ralf Wildenhues wrote:
> Without the URL change, the results are documented wrongly in the
> manual, missing
> #define PACKAGE_URL ""
>
> so this might be nice before 2.66. OK?
Given that argument, yes, this looks fine.
>
> The second patch has the downside of requiring maintenance should the
> formatting of the source contents change.
I only saw one patch? But I'm okay with the slight maintenance burden
if the file contents change slightly; at least with an automated test,
we are more likely to notice it as it happens, and decide at that time
if (and how) the test can be relaxed.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature