Re: Weird testsuite problems

[Pavel Roskin]

Hello again!

> However, pdksh-5.2.14 cannot run the testsuite. It hangs before doing
> anything else and exits only few seconds after I send it SIGTERM.

I've done some search in CVS history. The problem was introduced by the
following change (committed 2000/11/23 09:47:45)

2000-11-23  Akim Demaille  <address@hidden>

        Transform Autotest's body into a `for test; case $test'.
        As a known side effect, currently any code outside
        AT_SETUP/AT_CLEANUP is discarded.

        * acgeneral.m4 (_m4_divert(KILL)): Move to...
        * m4sugar.m4: here.
        * tests/atgeneral.m4 (AT_INIT): Use m4_divert_push/pop instead of
        m4_divert.
        Put all the tests inside a for;case.
        Define TESTS.
        (AT_SETUP, AT_CLEANUP): Open/close each case.

It appears to be a bug in psksh and zsh. I haven't tried to reduce
"testsuite" yet.

Now to the "warning" problem.

> : warning: improperly designed, please report to
> : warning: <address@hidden>.

It's indeed "improperly designed", since at-check-line is created and
checked in every test but is deleted only after the whole testsuite
finishes (not even when it starts).

This check is useless to find problems in the tests other than the first
one, since a failure to create at-check-line would be masked by the old
at-check-line left from another test.

This test is also useless after banner-* tests. Actually, it's where it's
failing - in banner-1 and banner-2.

Regards,
Pavel Roskin