Re: AC_DECL_SYS_SIGLIST is broken in latest autoconf

[Ben Pfaff]

address@hidden (Mike Castle) writes:

> In article <address@hidden>,
> Ben Pfaff  <address@hidden> wrote:
> >AC_DECL_SYS_SIGLIST doesn't #include <signal.h> before testing
> >for sys_siglist.  This breaks it on GNU/Linux and probably other
> >systems.  Here's a patch:
> 
> But then it's not the same as AC_CHECK_DECL([sys_siglist]), 

Why should it be the same as AC_CHECK_DECL([sys_siglist])?  It is
specialized for sys_siglist, so it should do what is necessary.

> and it's listed as an obsolete macro anyway.

So what?  If you're going to support an obsolete macro at all
then why not support it right?

> >--- autoconf-2.57.orig/lib/autoconf/specific.m4
> >+++ autoconf-2.57/lib/autoconf/specific.m4
> >@@ -60,7 +60,12 @@
> > # -------------------
> > AN_IDENTIFIER([sys_siglist],     [AC_CHECK_DECLS([sys_siglist])])
> > AU_DEFUN([AC_DECL_SYS_SIGLIST],
> >-[AC_CHECK_DECLS([sys_siglist])
> >+[AC_CHECK_DECLS([sys_siglist],,,[
> >+#include <signal.h>
> 
> I wrap the #include in #ifdef HAVE_SIGNAL_H myself.

Sounds like a good idea.
-- 
<address@hidden> <address@hidden> <address@hidden> <address@hidden>
  Stanford Ph.D. Student - MSU Alumnus - Debian Maintainer - GNU Developer
                              www.benpfaff.org