RE: possibly bug: autom4ate forgets to flush/close the output file?

[Viatcheslav.Sysoltsev]

Hello Eric,

Sure, there is the patch attached against 2.62 release.

Thanks for attention,

Regards, Slava



-----Original Message-----
From: Eric Blake [mailto:address@hidden 
Sent: Wednesday, April 09, 2008 2:02 PM
To: Viatcheslav.Sysoltsev
Cc: address@hidden
Subject: Re: possibly bug: autom4ate forgets to flush/close the output file?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Viatcheslav.Sysoltsev on 4/9/2008 1:46 AM:
| Good time of day,
|

Hello Viatcheslav, and thanks for the report,

| documentation for Autom4te::XFile says anyway implicitly in use cases,
that
| the file opened with open() must be closed with close().
|
| Of course, I tried to insert the $out->close() at the appropriate place
and
| this fixed my problem.

Would you mind posting your patch (as a context or unified diff against
either against 2.62 or against current git) for where you added the
close()?  Technically, exiting a process is supposed to flush and close
all streams implicitly, but as the gnulib project has discovered, not all
platforms obey this POSIX rule and an explicit close is probably the right
thing to add, even though no one else has ever encountered this problem.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkf8sEQACgkQ84KuGfSFAYBOUQCfS2l94RQdvhImvvuC8Skvkc3O
kjYAnjj93rUtkeMio0xyG3tgRDnfu3PO
=Cxeg
-----END PGP SIGNATURE-----

2.62.patch
Description: Binary data