autoconf
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: non-executable install-sh


From: Eric Blake
Subject: Re: non-executable install-sh
Date: Wed, 08 Oct 2008 19:55:11 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Patrick Welche on 10/8/2008 7:58 AM:
> Is this worth adding
> 
> diff --git a/lib/autoconf/programs.m4 b/lib/autoconf/programs.m4
> index 63f8a13..370ed31 100644
> --- a/lib/autoconf/programs.m4
> +++ b/lib/autoconf/programs.m4
> @@ -709,7 +709,7 @@ if test -z "$MKDIR_P"; then
>      # break other packages using the cache if that directory is
>      # removed, or if the value is a relative name.
>      test -d ./--version && rmdir ./--version
> -    MKDIR_P="$ac_install_sh -d"
> +    MKDIR_P="\$(SHELL) $ac_install_sh -d"

Thanks for the report.  As written, this patch proposal won't work (shell
requires ${SHELL}, only Makefiles allow $(SHELL).  But this has come up on
the archives before; perhaps the better fix is to guarantee that tarballs
can't be created without executable permission in the first place.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjtZH8ACgkQ84KuGfSFAYB6WwCfXv/KbD1eW/KvsC5ZnFWhdoUb
bxkAn2LbrNIY7w4Xy9xs3ka8eZVJlIe6
=tJx6
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]