automake-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Automake-commit] [SCM] GNU Automake branch, ng/experimental/master, cre


From: Stefano Lattarini
Subject: [Automake-commit] [SCM] GNU Automake branch, ng/experimental/master, created. v1.12-361-g3155551
Date: Sat, 02 Jun 2012 07:41:23 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Automake".

http://git.sv.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=3155551c638623bfe42f7f6b7c15f66d712956c4

The branch, ng/experimental/master has been created
        at  3155551c638623bfe42f7f6b7c15f66d712956c4 (commit)

- Log -----------------------------------------------------------------
commit 3155551c638623bfe42f7f6b7c15f66d712956c4
Author: Stefano Lattarini <address@hidden>
Date:   Thu May 31 17:52:51 2012 +0200

    [ng] vars: recognize escaped '#' correctly in a variable definition
    
    Regression revealed by a failure in test 't/backslash-tricks.sh', and
    caused by the recent merge of the 'ng/var-simplify' branch.
    
    It is worth noting that this change has a collateral effect: comments
    placed after the variable definition *must* now be separated with one
    or more spaces from said definition:
    
       # This won't work, and will produce a subtly broken Makefile
       foo = val# comment
       foo += val2
    
       # Please do this instead
       foo = val # comment
       foo += val2
    
    We believe that supporting the use of escaped '#' characters in variable
    definitions is more important than supporting the fringe case above.
    
    * lib/Automake/VarDef.pm (raw_value): Fix processing of stored value
    to account for escaped '#' characters.
    (value): Add a FIXME comment about a statement that is not strictly
    true anymore now that we assume GNU make.
    * t/backslash-tricks.sh: Extend a bit.
    * t/comment8.sh: Relax a bit, by placing spaces between the variable's
    definitions and the comments on the same line.  Extend in another
    respect, to watch against a regression introduced by the first draft of
    this commit.
    
    Signed-off-by: Stefano Lattarini <address@hidden>

-----------------------------------------------------------------------


hooks/post-receive
-- 
GNU Automake



reply via email to

[Prev in Thread] Current Thread [Next in Thread]