[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Automake-NG] [PATCH 4/4] [ng] cleanup: &Automake::Variable::hook is unu
From: |
Stefano Lattarini |
Subject: |
[Automake-NG] [PATCH 4/4] [ng] cleanup: &Automake::Variable::hook is unused, remove it |
Date: |
Thu, 10 May 2012 14:29:50 +0200 |
* lib/Automake/Variable.pm (hook): Delete, it's not used anymore.
(%_hooks): Likewise.
(define): Don't process variable hooks anymore.
Signed-off-by: Stefano Lattarini <address@hidden>
---
lib/Automake/Variable.pm | 27 ---------------------------
1 file changed, 27 deletions(-)
diff --git a/lib/Automake/Variable.pm b/lib/Automake/Variable.pm
index ab9baad..8171672 100644
--- a/lib/Automake/Variable.pm
+++ b/lib/Automake/Variable.pm
@@ -286,25 +286,6 @@ sub reject_var ($$)
=over 4
-=item C<Automake::Variable::hook ($varname, $fun)>
-
-Declare a function to be called whenever a variable
-named C<$varname> is defined or redefined.
-
-C<$fun> should take two arguments: C<$type> and C<$value>.
-When type is C<''> or <':'>, C<$value> is the value being
-assigned to C<$varname>. When C<$type> is C<'+'>, C<$value>
-is the value being appended to C<$varname>.
-
-=cut
-
-use vars '%_hooks';
-sub hook ($$)
-{
- my ($var, $fun) = @_;
- $_hooks{$var} = $fun;
-}
-
=item C<variables ([$suffix])>
Returns the list of all L<Automake::Variable> instances. (I.e., all
@@ -786,9 +767,6 @@ by by L<Automake::VarDef>). C<$pretty> applies only to real
assignments. I.e., it does not apply to a C<+=> assignment (except
when part of it is being done as a conditional C<=> assignment).
-This function will all run any hook registered with the C<hook>
-function.
-
=cut
sub define ($$$$$$$$)
@@ -985,11 +963,6 @@ sub define ($$$$$$$$)
$self->set ($cond, $def);
push @_var_order, $var;
}
-
- # Call any defined hook. This helps to update some internal state
- # *while* parsing the file. For instance the handling of SUFFIXES
- # requires this (see var_SUFFIXES_trigger).
- &{$_hooks{$var}}($type, $value) if exists $_hooks{$var};
}
=item C<variable_delete ($varname, address@hidden)>
--
1.7.9.5
- [Automake-NG] [PATCH 0/4] Prefer pattern rules over suffix rules, Stefano Lattarini, 2012/05/10
- [Automake-NG] [PATCH 1/4] [ng] am: prefer pattern rules over old-fashioned suffix rules, Stefano Lattarini, 2012/05/10
- [Automake-NG] [PATCH 2/4] [ng] rules: can pass deps to &Automake::Rule::define, Stefano Lattarini, 2012/05/10
- [Automake-NG] [PATCH 4/4] [ng] cleanup: &Automake::Variable::hook is unused, remove it,
Stefano Lattarini <=
- [Automake-NG] [PATCH 3/4] [ng] rules: forbid old-fashioned suffix rules, prefer pattern rules, Stefano Lattarini, 2012/05/10
- Re: [Automake-NG] [PATCH 0/4] Prefer pattern rules over suffix rules, Akim Demaille, 2012/05/10