automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug


From: Stefano Lattarini
Subject: Re: [Automake-NG] [PATCH 3/3] [ng] memoize: correctly work around a bug of GNU make < 3.83
Date: Tue, 15 May 2012 22:34:00 +0200

Hi Akim, sorry for the delay.

On 05/15/2012 04:32 PM, Akim Demaille wrote:
> 
> Le 15 mai 2012 à 15:34, Stefano Lattarini a écrit :
> 
>> I trust GNU make to be smart enough to handle an $(if ...) like the
>> one I've written in O(1).  Still, the use of $(or ...) is cleaner
>> and clearer, an portable back to GNU make 3.80 (our minimal required
>> version anyway), so I've switched to it.  At this point, I've also
>> made you the main author of the patch.
> 
> This is unfair: you wrote the code, the comments, the tests,
> the commit message, not to mention the handling of the PR
> (Public Relations, not Problem Report :).
>
And you found the non-trivial idea(s) without all of this would have
been impossible ...

> Making me co-author would already be way enough.
> 
Still, I won't argue with someone wanting to give me more credit :-)

So I've amended the patch to make me the main author and you the co-author;
I will push shortly if there is no more objection.

Best regards,
  Stefano




reply via email to

[Prev in Thread] Current Thread [Next in Thread]