automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Automake-NG] [PATCH 2/2] [ng] texinfo: take advantage of GNU make f


From: Stefano Lattarini
Subject: Re: [Automake-NG] [PATCH 2/2] [ng] texinfo: take advantage of GNU make features in several recipes
Date: Sat, 02 Jun 2012 13:57:56 +0200

On 05/31/2012 04:32 PM, Akim Demaille wrote:
> 
> Le 30 mai 2012 à 13:05, Stefano Lattarini a écrit :
> 
>> +## FIXME: Extra indirection required because Automake preprocessing groups
> 
> preprocessing
> 
>> +## FIXME: dependencies for a given '*-am' together, so that we might end up
>> +## FIXME: in our genereated Makefile with something like:
>> +## FIXME:
>> +## FIXME:   install-pdf-am: $(PDFS) install-pdf-local
>> +## FIXME:           ... [RECIPE] ...
>> +## FIXME: 
>> +## FIXME: which would cause a huge mess with our usages of '$^' in the 
>> recipes.
>
Actually, this is not Automake fault; even upon reading:

  install-pdf-am: $(PDFS)
        [RECIPE]

  install-pdf-am: install-pdf-local

GNU make would expand '$^' to "$(PDFS) install-pdf-local" in the recipe; this
is likely considered a feature, not a bug:

  <http://lists.gnu.org/archive/html/help-make/2012-05/msg00029.html>

So I've pushed the attached patch to fix the incorrect comment and clarify the
situation.

> Other than that, looks good.  Nice use of $(and).
> 
> 

Thanks,
  Stefano

Attachment: 0001-texinfo-fix-an-imprecise-comment.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]