Re: [Automake-NG] [PATCH 0/7] Move detection of possible typos in _SOURCES etc. at make runtime

[Akim Demaille]

Le 6 juin 2012 à 00:21, Stefano Lattarini a écrit :

> Stefano Lattarini (7):
>  [ng] coverage: conditional defn of lib_LIBRARIES and lib_LTLIBRARIES
>  [ng] automake: new global variable '%known_ltlibraries'
>  [ng] refactor: new make variables am__all_libs and am__all_ltlibs
>  [ng] warns: typos in _SOURCES etc. reported at make runtime
>  [ng] warns: typos in '_DEPENDENCIES' variables are now reported
>  [ng] warns: also report typos for 'LOG_DEPENDENCIES' variables
>  [ng] cleanup: unused variable in the automake script removed
> 
> Makefile.am                          |    1 +
> automake.in                          |   67 ++++++++-----------
> lib/am/check-typos.am                |   84 ++++++++++++++++++++++++
> lib/am/header-vars.am                |    8 +++
> lib/am/parallel-tests.am             |    3 +
> t/{all-progs.sh => all-prog-libs.sh} |   33 ++++++++--
> t/cond30.sh                          |   35 ++++++++--
> t/spell.sh                           |   29 +++++++-
> t/spell2.sh                          |   33 ++++++++--
> t/vartypo2.sh                        |   63 ------------------
> t/vartypos-deps.sh                   |  103 +++++++++++++++++++++++++++++
> t/vartypos.sh                        |  120 +++++++++++++++++++++-------------
> t/warnopts.sh                        |   27 ++++----
> 13 files changed, 429 insertions(+), 177 deletions(-)

Hi Stefano!

It looks good.

Maybe you should add failing cases for ancillary
functions such as errgrep to make sure they do
their job?  Say

! errgrep FAILURE

Also, is it ./defs that set -e?  Otherwise I
don't see how errgrep really checks something.  Or
is it just for the logs?

I don't understand well

./defs || Exit 1

I suppose it is defs that defines Exit, so this will
not work properly if one fails to find ./defs.  If the
point is to make sure that ./defs did not fail inside,
why wouldn't Exit be called from inside?