Re: [Automake-NG] [PATCH 04/26] [ng] texi: more target-specific variables use in '.info' build rules

[Akim Demaille]

Le 17 juin 2012 à 09:51, Stefano Lattarini a écrit :

> On 06/17/2012 08:44 AM, Akim Demaille wrote:
>> 
>> Le 16 juin 2012 à 23:29, Stefano Lattarini a écrit :
>> 
>>> -   if $(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS) %MAKEINFOFLAGS% -o 
>>> $@ $<; \
>>> +   if $(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS) \
>>> +                  $(am__makeinfoflags) -o $@ $<; \
>> 
>> Looks good.  Maybe
>> 
>> am__run_MAKEINFO = $(MAKEINFO) $(AM_MAKEINFOFLAGS) $(MAKEINFOFLAGS) 
>> $(am__makeinfoflags)
>> 
>> or something like this, would make it even clearer.
>> 
> But the above is only used in few places, and after all the refactorings
> this series does have taken place, it remains used in *two* places (and
> $(am__makeinfoflags) is gone).  Are you sure this so little duplication
> still warrants an internal variable?  If you do, I can write a follow-up
> patch in that direction to be applied at the end of the series.

Well, two is more than one, but not that much more :)  Leave as is at
the end.