[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [PATCH 05/14] [ng] clean: do not ignore errors while r
|
From: |
Stefano Lattarini |
|
Subject: |
Re: [Automake-NG] [PATCH 05/14] [ng] clean: do not ignore errors while removing files |
|
Date: |
Thu, 21 Jun 2012 20:44:18 +0200 |
On 06/21/2012 07:27 PM, Dave Hart wrote:
> On Thu, Jun 21, 2012 at 10:32 AM, Stefano Lattarini
> <address@hidden> wrote:
>> Possible culprits have been identified with the command "git grep '-rm\b'".
>>
>> * NG-NEWS: Update.
>> * lib/am/tags.am, lib/am/distdir.am, lib/am/dejagnu.am, lib/am/clean.am: Do
>> not invoke "rm" when the "-" recipe modifier: we now want the cleaning
>> recipes to fail if rm encounters an error.
>
> "when" is confusing here.
>
Typo. It was mean to be "with" actually. Still ...
> I suggest:
>
> * lib/am/tags.am, lib/am/distdir.am, lib/am/dejagnu.am, lib/am/clean.am: Do
> not prefix recipes invoking "rm" with the "-" recipe modifier: we now want
> the cleaning recipes to fail if rm encounters an error.
>
... I like your wording better, so I'll use it anyway.
Thanks,
Stefano
- Re: [Automake-NG] [PATCH 04/14] [ng] clean: revamp recipes and APIs to extend cleaning rules, (continued)
- [Automake-NG] [PATCH 06/14] [ng] automake: new global variable '%clean_dirs', Stefano Lattarini, 2012/06/21
- [Automake-NG] [PATCH 05/14] [ng] clean: do not ignore errors while removing files, Stefano Lattarini, 2012/06/21
- [Automake-NG] [PATCH 08/14] [ng] cleanup: remove 'depend.am', Stefano Lattarini, 2012/06/21
- [Automake-NG] [PATCH 11/14] [ng] cleanup: merge '%compile_clean_files' in '%clean_files', Stefano Lattarini, 2012/06/21
- [Automake-NG] [PATCH 09/14] [ng] clean: don't remove object files in '.' unconditionally, Stefano Lattarini, 2012/06/21
- [Automake-NG] [PATCH 07/14] [ng] refactoring: move definition of $(am__mv) in depend2.am, Stefano Lattarini, 2012/06/21