Re: [Automake-NG] [PATCH 03/14] [ng] clean: simplify cleaning of compiled objects

[Akim Demaille]

Le 21 juin 2012 à 20:34, Stefano Lattarini <address@hidden> a écrit :

> Hi Akim.
> 
> On 06/21/2012 02:35 PM, Akim Demaille wrote:
>> 
>> Le 21 juin 2012 à 12:32, Stefano Lattarini a écrit :
>> 
>> OK.
>> 
>>> +    my @mostly_rms = map { "\t-rm -f $_" } sort keys %compile_clean_files;
>>>    my ($coms, $vars, $rules) =
>>>      &file_contents_internal (1, "$libdir/am/compile.am",
>>>                   new Automake::Location,
>>> -                   ('STDINC' => ! option 'nostdinc',
>>> -                'MOSTLYRMS' => join ("\n", @mostly_rms),
>>> -                'DISTRMS' => join ("\n", @dist_rms)));
>>> +                   'STDINC' => ! option 'nostdinc',
>>> +                   'MOSTLYRMS' => join ("\n", @mostly_rms));
>>>    $output_vars .= $vars;
>>>    $output_rules .= "$coms$rules";
>>> }
>> 
>> 
>> Given that that the minimum command line length is probably known,
>> I suppose we can do much more that one file per rm.
>> 
> This is true, but is also rendered moot by the later patches, so I
> wouldn't care too much, and just leave the patch as-is.  Agreed?

Yes, of course.  I was commenting while reading, and
later patches definitely address my concerns.