Re: [Automake-NG] [PATCH v2 2/2] dist: add back support for obsolete dist-* options

[Stefano Lattarini]

On 08/22/2012 02:43 PM, Paolo Bonzini wrote:
> Il 22/08/2012 14:41, Stefano Lattarini ha scritto:
>>>> It is a bit ugly that _process_option_list has to know about the
>>>> no-dist-gzip option in order to give a warning.  This way, I can give a
>>>> superior error message if somebody specifies no-dist-xz.
>>>>
>> That option would be just flatly rejected by mainline Automake as well,
>> so no need to worry.
> 
> I do worry, because degrading that to a warning is a regression.
>
Unless I'm mistaken, 'no-dist-xz' would still cause an error.  While
admittedly 'dist-foo' would cause only a warning at Automake runtime,
but an error at make runtime (like "AM_DIST_FORMATS = foo" would do).
But that's OK, and I don't plan nor want to change it.

>>>> But if you added support for another dist-fooz option you wouldn't have
>>>> to touch automake.in nor lib/Automake at all.
>>>>
>> I wouldn't have to that now either -- the 'dist-(.*)' regex would take
>> care of it automatically.  I'd just have to edit 'lib/am/distcheck.mk'.
> 
> Yeah, that's correct.
> 
> Paolo

Regards,
  Stefano