Re: [Automake-NG] [PATCH 2/5] [ng] refactor: remove all uses of $(am__nobase_strip{, _setup})

[Akim Demaille]

Le 9 août 2012 à 12:56, Stefano Lattarini a écrit :

> Prefer using GNU make built-ins $(patsubst) and $(notdir) instead.
> This entails a partial or complete rewrites of several install and/or
> uninstall rules.
> 
> This change doesn't offer any serious simplification, being just a
> step in the general direction of moving more non-trivial processing
> to GNU make.  The change actually slows down some install/uninstall
> rules, but leave the touched codebase simpler and more malleable by
> future changes; performance improvements can be re-introduced later,
> this time with more use of GNU make features rather than sed+awk
> chicanery.
> 
> This change also breaks the test 't/instmany-python.sh'; no big
> deal though, as that will be fixed again soon by further refactoring.
> 
> * lib/am/data.am: Rewritten some install/uninstall rules to avoid

Rewrite :)

> using '$(am__nobase_strip)' and '$(am__nobase_strip_setup)'.
> * lib/am/libs.am: Likewise.
> * lib/am/lisp.am: Likewise.
> * lib/am/python.am: Likewise.
> * lib/am/scripts.am: Likewise.  Also drop some performance optimization
> that, albeit useful and legitimate, were making the code too much
> complicated to work on.
> (am__nobase_strip): Remove, no more used.
> (am__nobase_strip_setup): Likewise, its only remaining use inlined ...
> (am__nobase_list): ... here.

Seems to be much simpler, nice!