[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Redefined extension caused problems
From: |
Akim Demaille |
Subject: |
Re: Redefined extension caused problems |
Date: |
09 Jan 2002 15:54:19 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) |
>>>>> "Tom" == Tom Tromey <address@hidden> writes:
>>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:
adl> + * automake.in (file_contents_internal): Introduce two
adl> variables, + $is_rule and $discard_rules to track rules spanning
adl> across multiple + paragraphs. This fixes a very nasty bug
adl> reported by Dmitry Mikhin + where only the first paragraph of
adl> such a multi-paragraph rule was + discarded, but leaves many
adl> latent bugs (see the FIXMEs).
Tom> I think Akim will have to decide on this patch. I'm not that
Tom> familiar with the code. Or, if you feel confident, you can go
Tom> ahead yourself...
It looks OK to me.
To summarize, I believe that until we have a _real_ parser, we have to
follow this crazy track. Someday, when one of us really has time, the
next major massage of Automake is writing a real parser, with a real
grammar, an AST, and use them for user and Automake files.
_Then_ we will have real variable support, some additional constructs
that will help moving code from automake to *.am etc.
In between, what matters is keeping things clear and high-level.
That's why I promote paragraph reading as opposed to line-based.