Re: Test for --help and --version in gnits mode

[Alexandre Duret-Lutz]

Hi,

Some comments:

|       * automake.texi (Options): document std-options

This chunk is missing from the patch you sent.

[...]
|       &pretty_print_rule ("\t\$(MAKE) \$(AM_MAKEFLAGS)", "\t  ",
| !                     uniq (sort @check_tests))

Isn't "uniq (@check_tests)" enough?

[...]

| + .PHONY check-options: check-%DIR%PROGRAMS
| + check-%DIR%PROGRAMS:

Would it be correct to make check-%DIR%PROGRAMS dependent upon
$(%DIR%_PROGRAMS)?

| +     bad=0; pid=$$$$; list="$(%DIR%_PROGRAMS)"; for p in $$list; do \
| +       for opt in --help --version; do \
| +         if test -f $$p; then \
| +           p=./$$p; \
| +         else exit 1; fi; \

It seems the ajustement of $p could be done outside the `for opt' loop.

| +         if $$p $$opt > .chkout$$pid 2> .chkerr$$pid \
| +              && test -n "`cat .chkout$$pid`" \
| +              && test -z "`cat .chkerr$$pid`"; then :; \

Will Tim like these filenames? :)

[...]
-- 
Alexandre Duret-Lutz