automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: workaround for make.test failure on NetBSD


From: Alexandre Duret-Lutz
Subject: FYI: workaround for make.test failure on NetBSD
Date: Fri, 22 Feb 2002 18:38:18 +0100
User-agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.1 (i386-debian-linux-gnu)

>>> "Tom" == Tom Tromey <address@hidden> writes:

 >>>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:
 adl> I managed to reproduce this (on NetBSD 1.5.2), and reduced the
 adl> failure to the following script:

 adl> % cat foo.sh
 adl> set -e
 adl> for x in a; do
 adl> BAR="foo"
 adl> false && echo true
 adl> echo mumble
 adl> done

 Tom> We already have added workarounds for this bugs in other places.
 Tom> If you want to add one to make.test, I don't have a problem with it.

I've just committed the following.

Index: ChangeLog
===================================================================
RCS file: /cvs/automake/automake/ChangeLog,v
retrieving revision 1.1767
diff -u -r1.1767 ChangeLog
--- ChangeLog   2002/02/20 18:10:17     1.1767
+++ ChangeLog   2002/02/22 17:30:20
@@ -1,3 +1,9 @@
+2002-02-22  Alexandre Duret-Lutz  <address@hidden>
+
+       * tests/make.test: Revert the grep logic to work around a bug
+       in NetBSD sh (see NetBSD Problem Report #11542).
+       Reported by Patrick Welche.
+
 2002-02-20  Tim Van Holder  <address@hidden>
 
        * m4/lispdir.m4: Redirect /dev/null to stdin when running $EMACS
Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.163
diff -u -r1.163 THANKS
--- THANKS      2002/01/18 23:08:26     1.163
+++ THANKS      2002/02/22 17:30:20
@@ -126,6 +126,7 @@
 OKUJI Yoshinori                address@hidden
 Olivier Louchart-Fletcher address@hidden
 Olly Betts             address@hidden
+Patrick Welche         address@hidden
 Paul Berrevoets                address@hidden
 Paul D. Smith          address@hidden
 Paul Eggert            address@hidden
Index: tests/make.test
===================================================================
RCS file: /cvs/automake/automake/tests/make.test,v
retrieving revision 1.5
diff -u -r1.5 make.test
--- make.test   2001/12/26 08:22:06     1.5
+++ make.test   2002/02/22 17:30:20
@@ -27,18 +27,18 @@
 export AUTOMAKE
 
 # Do the test twice -- once with make and once with make -w.
-# This tests for a bug reported by Rainer Orth.
+# This tests for a bug reported by Rainer Orth (see PR 175).
 
 save="$MAKE"
 for flag in '' -w; do
    MAKE="$save $flag" ./configure
 
-   fgrep 'am__include = #' Makefile && exit 1
+   fgrep 'am__include = include' Makefile
 
    touch configure.in
    $MAKE $flag
 
-   fgrep 'am__include = #' Makefile && exit 1
+   fgrep 'am__include = include' Makefile
 
    rm -f config.cache
 done

-- 
Alexandre Duret-Lutz




reply via email to

[Prev in Thread] Current Thread [Next in Thread]