Re: automake/370: Option ansi2knr mishandles sources in different directories

[Kevin Ryde]

Alexandre Duret-Lutz <address@hidden> writes:
>
> Anyway.  I've installed the following patch on branch-1-7 and HEAD.
> It's the same as yesterday, plus a fix to clean the _.c files
> left in subdirectories when subdir-objects is used.

Looks good.

Are the clean rules for subdir/foo_.c meant to happen only under
subdir-objects?  They seem to be generated without that option too.

And as a suggestion, the cleaning might like to do something similar
to the rule for *_.c,

        -test "$U" = "" || rm -f *_.c

so as to clean only when ansi2knr is in fact in use.

The benefit would be that on a DOS 8.3 filesystem there'd be no risk
of "rm subdir/longnamefile_.c" getting truncated to "rm
subdir/longname.c" and removing the source file.  In particular this
would help DJGPP.

> +         # be preprocessed for only once set of options if it were
                                       ^^^^
                                       typo perhaps

> Index: tests/ansi7.test
> ===================================================================
>  ./configure am_cv_prog_cc_stdc=no

Since AM_PROG_CC_STDC these days just uses AC_PROG_CC, I think the
cache variable to force a pretend k&r is ac_cv_prog_cc_stdc, not
am_...