automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Quoting of AC_PACKAGE_TARNAME & AC_PACKAGE_VERSION


From: Brian Ford
Subject: Quoting of AC_PACKAGE_TARNAME & AC_PACKAGE_VERSION
Date: Wed, 11 Dec 2002 17:38:51 -0600 (CST)

Please Cc me on replies as I am not currently subscribed to any of the
lists.  Thanks.

AM_INIT_AUTOMAKE does not currently quote PACKAGE_TARNAME &
AC_PACKAGE_VERSION correctly.  As such, it can not handle spaces, or
possibly other constructs.

See autoconf/lib/autoconf/general.m4 for a proper example.  A patch
follows:

Index: ChangeLog
===================================================================
RCS file: /cvs/automake/automake/ChangeLog,v
retrieving revision 1.2112
diff -u -w -r1.2112 ChangeLog
--- ChangeLog   11 Dec 2002 20:51:02 -0000      1.2112
+++ ChangeLog   11 Dec 2002 23:32:57 -0000
@@ -1,3 +1,8 @@
+2002-12-11  Brian Ford  <address@hidden>
+
+       * m4/init.m4 (AM_INIT_AUTOMAKE): Properly quote AC_PACKAGE_TARNAME
+       and AC_PACKAGE_VERSION.
+
 2002-12-11  Alexandre Duret-Lutz  <address@hidden>

        * automake.texi (ANSI): Since Autoconf 2.54, LIBOBJ and LTLIBOBJ
Index: m4/init.m4
===================================================================
RCS file: /cvs/automake/automake/m4/init.m4,v
retrieving revision 1.50
diff -u -w -r1.50 init.m4
--- m4/init.m4  16 Sep 2002 10:12:22 -0000      1.50
+++ m4/init.m4  11 Dec 2002 23:32:57 -0000
@@ -73,8 +73,8 @@
  AC_SUBST([PACKAGE], [$1])dnl
  AC_SUBST([VERSION], [$2])],
 [_AM_SET_OPTIONS([$1])dnl
- AC_SUBST([PACKAGE], [AC_PACKAGE_TARNAME])dnl
- AC_SUBST([VERSION], [AC_PACKAGE_VERSION])])dnl
+ AC_SUBST([PACKAGE], ['AC_PACKAGE_TARNAME'])dnl
+ AC_SUBST([VERSION], ['AC_PACKAGE_VERSION'])])dnl

 _AM_IF_OPTION([no-define],,
 [AC_DEFINE_UNQUOTED(PACKAGE, "$PACKAGE", [Name of package])

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444




reply via email to

[Prev in Thread] Current Thread [Next in Thread]