Re: --help and --version should exit with nonzero status on write failures

[Alexandre Duret-Lutz]

Bummer, just discovered a few more...

2005-02-02  Alexandre Duret-Lutz  <address@hidden>

        * lib/elisp-comp: Use `(exit N); exit N', not `(exit N); exit';
        see 2004-12-17.
        * lib/mdate-sh, lib/py-compile, lib/ylwrap: Exit with nonzero
        status if a write failure occurs with --help or --version option,
        as below.

Index: lib/elisp-comp
===================================================================
RCS file: /cvs/automake/automake/lib/elisp-comp,v
retrieving revision 1.12
diff -u -r1.12 elisp-comp
--- lib/elisp-comp      2 Feb 2005 20:58:58 -0000       1.12
+++ lib/elisp-comp      2 Feb 2005 21:07:56 -0000
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Copyright (C) 1995, 2000, 2003, 2004, 2005  Free Software Foundation, Inc.
 
-scriptversion=2005-02-02.21
+scriptversion=2005-02-02.22
 
 # Franc,ois Pinard <address@hidden>, 1995.
 #
@@ -77,7 +77,7 @@
   mv *.elc ..
 ) || exit $?
 
-(exit 0); exit
+(exit 0); exit 0
 
 # Local Variables:
 # mode: shell-script
Index: lib/mdate-sh
===================================================================
RCS file: /cvs/automake/automake/lib/mdate-sh,v
retrieving revision 1.13
diff -u -r1.13 mdate-sh
--- lib/mdate-sh        8 Dec 2004 20:33:11 -0000       1.13
+++ lib/mdate-sh        2 Feb 2005 21:07:56 -0000
@@ -1,9 +1,10 @@
 #!/bin/sh
 # Get modification time of a file or directory and pretty-print it.
 
-scriptversion=2004-12-08.12
+scriptversion=2005-02-02.22
 
-# Copyright (C) 1995, 1996, 1997, 2003, 2004 Free Software Foundation, Inc.
+# Copyright (C) 1995, 1996, 1997, 2003, 2004, 2005 Free Software
+# Foundation, Inc.
 # written by Ulrich Drepper <address@hidden>, June 1995
 #
 # This program is free software; you can redistribute it and/or modify
@@ -42,11 +43,11 @@
 
 Report bugs to <address@hidden>.
 EOF
-    exit 0
+    exit $?
     ;;
   -v | --v*)
     echo "mdate-sh $scriptversion"
-    exit 0
+    exit $?
     ;;
 esac
 
Index: lib/py-compile
===================================================================
RCS file: /cvs/automake/automake/lib/py-compile,v
retrieving revision 1.6
diff -u -r1.6 py-compile
--- lib/py-compile      5 Dec 2004 16:12:31 -0000       1.6
+++ lib/py-compile      2 Feb 2005 21:07:56 -0000
@@ -1,9 +1,9 @@
 #!/bin/sh
 # py-compile - Compile a Python program
 
-scriptversion=2004-12-05.17
+scriptversion=2005-02-02.22
 
-# Copyright (C) 2000, 2001, 2003, 2004  Free Software Foundation, Inc.
+# Copyright (C) 2000, 2001, 2003, 2004, 2005  Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -68,11 +68,11 @@
 
 Report bugs to <address@hidden>.
 EOF
-      exit 0
+      exit $?
       ;;
     -v|--v*)
       echo "py-compile $scriptversion"
-      exit 0
+      exit $?
       ;;
     *)
       files="$files $1"
Index: lib/ylwrap
===================================================================
RCS file: /cvs/automake/automake/lib/ylwrap,v
retrieving revision 1.25
diff -u -r1.25 ylwrap
--- lib/ylwrap  10 Sep 2004 18:47:08 -0000      1.25
+++ lib/ylwrap  2 Feb 2005 21:07:56 -0000
@@ -1,9 +1,9 @@
 #! /bin/sh
 # ylwrap - wrapper for lex/yacc invocations.
 
-scriptversion=2004-09-10.20
+scriptversion=2005-02-02.22
 
-# Copyright (C) 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004
+# Copyright (C) 1996, 1997, 1998, 1999, 2001, 2002, 2003, 2004, 2005
 #   Free Software Foundation, Inc.
 #
 # Written by Tom Tromey <address@hidden>.
@@ -56,11 +56,11 @@
 
 Report bugs to <address@hidden>.
 EOF
-    exit 0
+    exit $?
     ;;
   -v|--v*)
     echo "ylwrap $scriptversion"
-    exit 0
+    exit $?
     ;;
 esac
 

-- 
Alexandre Duret-Lutz