RE: mdate-sh borks on uid/gid containing a space

[Dave Korn]

On 29 March 2007 15:38, Stepan Kasal wrote:

> Hello,
> 
> On Thu, Mar 29, 2007 at 12:40:12AM +0100, Dave Korn wrote:
>> On 29 March 2007 00:26, Ralf Wildenhues wrote:
>>
<http://thread.gmane.org/gmane.comp.sysutils.automake.patches/2730/focus=2740>
>>> Eric's patch seems to indicate that line 92 needs changed, too.
>>> (I haven't tested any on w32.)
>> 
>>   I don't quite understand that myself; ISTM that having -n in $ls_command
>> should do the job for both cases.
> 
> A wild guess:
> 
> Though the current situation is this (quoting Eric):
> 
> $ \ls -ld /
> drwxrwx---+ 14 eblake Users 0 Feb  2 07:58 /
> $ \ls -lLd doc/m4.texinfo
> -rw-r--r-- 1 eblake Domain Users 221922 Mar  1 14:50 doc/m4.texinfo
> 
> it might be possible that even the user or group owner of / would
> have a blank it its name.  (With Cygwin, one never knows.)
> 
> So it is safer to use -n with ls /, too.

  Umm, yes, that's true, but not relevant; what I was pointing out is that the
-n gets added to the $ls_command variable, so it would already be included in
the command invoked on line 92, and if you take a second look at the patch,
you'll notice that the change to line 92 isn't about adding -n, it's about
taking away -l and -d.

  Ah, hang on, now I see why; those flags are /also/ already included in
$ls_command, so they're superfluous on line 92; it's just a minor tidy up.


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....