Re: Python 3.0 support

[Ralf Wildenhues]

Hi Johan,

* Johan Dahlin wrote on Sun, Jul 27, 2008 at 03:53:58PM CEST:
> Hi, here are 4 patches adding Python 3.0 support for Automake.

Thank you for working on these patches.

> Python 3.0 changes has major backwards incompatible changes, we have to 
> be rather careful to use a subset which works on both 2.x and 3.x.
> The patches have been tested on Python 2.5 and 3.0. I am confident that
> they will work on versions as early as 2.0. Support for versions
> prior to that has been dropped (2.0 was released in 2000) and that is
> mentioned in the NEWS file.

Sounds fair to me, if support for pre-2.0 is difficult to keep.
As I don't know python very well, can you elaborate a bit on
why that is?

> I'm in the process of assigning my copyright to GNU.

Great.  Could you ping me when the assignment has been completed?

A minor nits to the patches is below.

Thanks,
Ralf

> From: Johan Dahlin <address@hidden>
> Date: Sun, 27 Jul 2008 15:19:35 +0200
> Subject: [PATCH] Update py-compile to support python 3.0. This also drops 
> support for python < 2.0.

Your patches are lacking GNU-style ChangeLog entries.  If you could add
them, that would be great, otherwise I will.  Note that for Automake, we
typically let the commit log entry be the ChangeLog entry without the
author attribution and indentation, and with an additional newline after
the first line.  Also, I'd prefer to have a short first line as summary.

Anyway, as I said if you don't add this I can just do it.