[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recrea
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation. |
Date: |
Tue, 17 Mar 2009 23:24:29 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hello Akim,
addressing part of your reply:
* Akim Demaille wrote on Sat, Mar 14, 2009 at 03:00:42PM CET:
> Le 14 mars 09 à 14:46, Ralf Wildenhues a écrit :
>> * Akim Demaille wrote on Sat, Mar 14, 2009 at 02:25:03PM CET:
>>> FWIW, I also noticed that we sometimes had tests that were removed/
>>> renamed that were still marked as XFAILs. So I use this in some of
>>> my test suites:
>>
>> Why are these not simply treated as hard failures?
>
> Hum, I don't understand what you mean here, they are. My code checks
> that members of XFAIL_TESTS and TFAIL_TESTS exist, and reports the
> missing ones.
Never mind. I misunderstood your prior message completely.
Your rule can be simplified a lot: :-)
# Check that XFAIL tests do exist.
check-test-list-XFAIL: $(XFAIL_TESTS)
check-test-list-TFAIL: $(TFAIL_TESTS)
.PHONY: check-test-list-XFAIL check-test-list-TFAIL
Of course that will also update the actual tests if they are generated
themselves, but IIUC then that should not be a problem for you.
You could even
check-local: check-test-list-XFAIL check-test-list-TFAIL
Cheers,
Ralf
- Re: [PATCH 07] Use append mode to capture parallel test output., (continued)
[PATCH 08] Match XFAIL_TESTS correctly with Solaris make., Ralf Wildenhues, 2009/03/14
[PATCH 09] Mark check-html and check-TESTS as recursive for BSD make., Ralf Wildenhues, 2009/03/14
[PATCH 10] Fix parallel-tests with empty $(TESTS) for BSD make., Ralf Wildenhues, 2009/03/14
Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation., Ralf Wildenhues, 2009/03/14
- Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation., Akim Demaille, 2009/03/14
- Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation., Ralf Wildenhues, 2009/03/19
- parallel-tests: warn about $(srcdir), $(top_srcdir) in TESTS., Ralf Wildenhues, 2009/03/28
- Re: parallel-tests: warn about $(srcdir), $(top_srcdir) in TESTS., Akim Demaille, 2009/03/30
Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation., Akim Demaille, 2009/03/30
Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation., Ralf Wildenhues, 2009/03/30
Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation., Ralf Wildenhues, 2009/03/22
check-html: Always create HTML output, note conversion failure., Ralf Wildenhues, 2009/03/28
parallel-tests: redo lazy checking: recheck and RECHECK_LOGS., Ralf Wildenhues, 2009/03/28
Re: parallel-tests: redo lazy checking: recheck and RECHECK_LOGS., Akim Demaille, 2009/03/30