automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Remove redundant unset of variable TESTS from some test scripts.


From: Stefano Lattarini
Subject: [PATCH] Remove redundant unset of variable TESTS from some test scripts.
Date: Thu, 4 Mar 2010 21:24:53 +0100
User-agent: KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; )

A simple cleanup patch.  Some test scripts still explicitly unset
the `TESTS' variable, but this is no more required, since `TESTS'
is unset in the `defs' script starting at least from commit
40c3936593bd5fc35a13641ad031445d419e38bf (Mon Apr 6 2009),
The attached patch fixes this minor wart.

Regards,
     Stefano
From 59faa75d4d2e796a81646c4acc275a0e15c7e687 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Thu, 4 Mar 2010 21:09:13 +0100
Subject: [PATCH] Remove redundant unset of variable TESTS from some test 
scripts.

* tests/color.test: Do not unset the `TESTS' variable, as it's
already unset in the `defs' file.
* tests/check5.test: Likewise.
* tests/check8.test: Likewise.
* tests/check9.test: Likewise.
* tests/check10.test: Likewise.
* tests/check11.test: Likewise.
* tests/parallel-tests.test: Likewise.
* tests/parallel-tests3.test: Likewise.
* tests/parallel-tests4.test: Likewise.
* tests/parallel-tests5.test: Likewise.
* tests/parallel-tests6.test: Likewise.
* tests/parallel-tests7.test: Likewise.
---
 ChangeLog                  |   17 +++++++++++++++++
 tests/check10.test         |    2 --
 tests/check11.test         |    2 --
 tests/check5.test          |    1 -
 tests/check8.test          |    2 --
 tests/check9.test          |    2 --
 tests/color.test           |    2 --
 tests/parallel-tests.test  |    2 --
 tests/parallel-tests3.test |    2 --
 tests/parallel-tests4.test |    2 --
 tests/parallel-tests5.test |    2 --
 tests/parallel-tests6.test |    2 --
 tests/parallel-tests7.test |    2 --
 13 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 795f839..d4d34cd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2010-03-04  Stefano Lattarini  <address@hidden>
+
+       Remove redundant unset of variable TESTS from some test scripts.
+       * tests/color.test: Do not unset the `TESTS' variable, as it's
+       already unset in the `defs' file.
+       * tests/check5.test: Likewise.
+       * tests/check8.test: Likewise.
+       * tests/check9.test: Likewise.
+       * tests/check10.test: Likewise.
+       * tests/check11.test: Likewise.
+       * tests/parallel-tests.test: Likewise.
+       * tests/parallel-tests3.test: Likewise.
+       * tests/parallel-tests4.test: Likewise.
+       * tests/parallel-tests5.test: Likewise.
+       * tests/parallel-tests6.test: Likewise.
+       * tests/parallel-tests7.test: Likewise.
+
 2010-03-01  Ralf Wildenhues  <address@hidden>
 
        Fix cscope test on systems without working Fortran compiler.
diff --git a/tests/check10.test b/tests/check10.test
index 76af452..c832afb 100755
--- a/tests/check10.test
+++ b/tests/check10.test
@@ -54,8 +54,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE
 
-unset TESTS || :
-
 ./configure
 (
   # Do not check for failure in this subshell
diff --git a/tests/check11.test b/tests/check11.test
index d3118a7..12251f4 100755
--- a/tests/check11.test
+++ b/tests/check11.test
@@ -39,8 +39,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 env TESTS=skip $MAKE -e check >stdout
 cat stdout
diff --git a/tests/check5.test b/tests/check5.test
index 857432b..ce46b72 100755
--- a/tests/check5.test
+++ b/tests/check5.test
@@ -46,7 +46,6 @@ END
 cp one.c two.c
 
 ./configure
-unset TESTS || :
 $MAKE check
 test -f ok
 EXEEXT=.bin $MAKE -e print-tests >output
diff --git a/tests/check8.test b/tests/check8.test
index 7936582..8abcd8b 100755
--- a/tests/check8.test
+++ b/tests/check8.test
@@ -64,8 +64,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 AM_COLOR_TESTS=always $MAKE -e check >stdout 2>stderr &&
   { cat stdout; cat stderr >&2; Exit 1; }
diff --git a/tests/check9.test b/tests/check9.test
index ed88690..c0418ae 100755
--- a/tests/check9.test
+++ b/tests/check9.test
@@ -64,8 +64,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 $MAKE all
 $MAKE check
diff --git a/tests/color.test b/tests/color.test
index a5bd063..3fd8c42 100755
--- a/tests/color.test
+++ b/tests/color.test
@@ -99,8 +99,6 @@ spawn $env(MAKE) -e check
 expect eof
 END
 
-unset TESTS || :
-
 AM_COLOR_TESTS=always $MAKE -e check >stdout && { cat stdout; Exit 1; }
 cat stdout
 test_color
diff --git a/tests/parallel-tests.test b/tests/parallel-tests.test
index 385cef3..14ec11d 100755
--- a/tests/parallel-tests.test
+++ b/tests/parallel-tests.test
@@ -61,8 +61,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 # No hard errors: all tests should be run, there should be one failure.
 env DISABLE_HARD_ERRORS=yes $MAKE -e check >stdout && { cat stdout; Exit 1; }
diff --git a/tests/parallel-tests3.test b/tests/parallel-tests3.test
index d631d67..3d69c62 100755
--- a/tests/parallel-tests3.test
+++ b/tests/parallel-tests3.test
@@ -52,8 +52,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 for build in serial parallel; do
   mkdir $build
   cd $build
diff --git a/tests/parallel-tests4.test b/tests/parallel-tests4.test
index d842486..4fb2e25 100755
--- a/tests/parallel-tests4.test
+++ b/tests/parallel-tests4.test
@@ -56,8 +56,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 $MAKE
 $MAKE check
diff --git a/tests/parallel-tests5.test b/tests/parallel-tests5.test
index a7bbc9e..8841ac8 100755
--- a/tests/parallel-tests5.test
+++ b/tests/parallel-tests5.test
@@ -60,8 +60,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 $MAKE -j4 check
 $MAKE distcheck
diff --git a/tests/parallel-tests6.test b/tests/parallel-tests6.test
index 5dbb433..fa6200f 100755
--- a/tests/parallel-tests6.test
+++ b/tests/parallel-tests6.test
@@ -34,8 +34,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 $MAKE check >stdout || { cat stdout; Exit 1; }
 cat stdout
diff --git a/tests/parallel-tests7.test b/tests/parallel-tests7.test
index c2ae63a..451bcc0 100755
--- a/tests/parallel-tests7.test
+++ b/tests/parallel-tests7.test
@@ -77,8 +77,6 @@ $ACLOCAL
 $AUTOCONF
 $AUTOMAKE -a
 
-unset TESTS || :
-
 ./configure
 $MAKE
 $MAKE check
-- 
1.6.5


reply via email to

[Prev in Thread] Current Thread [Next in Thread]