[PATCH] Improve timing of generation of generated test scripts.

[Stefano Lattarini]

Hello automakers.

Anothor small cosmetic patch; it adds the list of generated tests 
($(parallel_tests)) to the check_SCRIPTS variable, so that all the 
automatically generated tests are created before starting to run any 
test script in the testsuite.

This patch offer the advantage to help to catch errors in tests' 
generation very early (now, since $(parallel_tests) is added at the 
end of $(TESTS), any such error would manifest itself only after all 
the other tests have been already run).  On the other hand, a failure
in the generation of the $(parallel_tests) would prevent all the tests 
from running, which might be suboptimal in some situations (e.g. 
automated builds).

Here I just offer the simple patch; it's up to you to decide if its 
benefits outweight its downsides.

Regards,
     Stefano

From 34c6aaac9fdb8d5165fff68707762f41697a40f5 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Sun, 7 Mar 2010 16:07:56 +0100
Subject: [PATCH] Improve timing of generation of generated test scripts.

* tests/Makefile.am (check_SCRIPTS): Add `$(parallel_tests)', so
that the generated `*-p.test' scripts are created before starting
to run the testsuite when `make check' is used.
---
 ChangeLog         |    7 +++++++
 tests/Makefile.am |   13 ++++++++-----
 tests/Makefile.in |   11 +++++++----
 3 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 1e6191c..112600a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-03-07  Stefano Lattarini  <address@hidden>
+
+       Improve timing of generation of generated test scripts.
+       * tests/Makefile.am (check_SCRIPTS): Add `$(parallel_tests)', so
+       that the generated `*-p.test' scripts are created before starting
+       to run the testsuite when `make check' is used.
+
 2010-03-06  Ralf Wildenhues  <address@hidden>
 
        Formatting cleanups in macro comments.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index acc979c..0da0135 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -25,6 +25,14 @@ txinfo5.test
 
 include $(srcdir)/parallel-tests.am
 
+EXTRA_DIST = ChangeLog-old gen-parallel-tests $(TESTS)
+
+# Each test case depends on defs, aclocal, and automake.
+check_SCRIPTS = defs aclocal-$(APIVERSION) automake-$(APIVERSION)
+# And we want to have all the automatically generated tests script before
+# starting to run the testsuite.
+check_SCRIPTS += $(parallel_tests)
+
 $(srcdir)/parallel-tests.am: gen-parallel-tests Makefile.am
        $(AM_V_GEN)(cd $(srcdir) && $(SHELL) ./gen-parallel-tests) >$@
 
@@ -772,11 +780,6 @@ yaccpp.test \
 yaccvpath.test \
 $(parallel_tests)
 
-EXTRA_DIST = ChangeLog-old gen-parallel-tests $(TESTS)
-
-# Each test case depends on defs, aclocal, and automake.
-check_SCRIPTS = defs aclocal-$(APIVERSION) automake-$(APIVERSION)
-
 clean-local: clean-local-check
 .PHONY: clean-local-check
 clean-local-check:
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 1d70152..cf5dbf4 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -279,6 +279,13 @@ pr401-p.test \
 pr401b-p.test \
 pr401c-p.test
 
+EXTRA_DIST = ChangeLog-old gen-parallel-tests $(TESTS)
+
+# Each test case depends on defs, aclocal, and automake.
+# And we want to have all the automatically generated tests script before
+# starting to run the testsuite.
+check_SCRIPTS = defs aclocal-$(APIVERSION) automake-$(APIVERSION) \
+       $(parallel_tests)
 MAINTAINERCLEANFILES = $(parallel_tests)
 TESTS = \
 aclibobj.test \
@@ -1016,10 +1023,6 @@ yaccpp.test \
 yaccvpath.test \
 $(parallel_tests)
 
-EXTRA_DIST = ChangeLog-old gen-parallel-tests $(TESTS)
-
-# Each test case depends on defs, aclocal, and automake.
-check_SCRIPTS = defs aclocal-$(APIVERSION) automake-$(APIVERSION)
 all: all-am
 
 .SUFFIXES:
-- 
1.6.5