[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Avoid another use of `chmod -R'.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 1/2] Avoid another use of `chmod -R'. |
Date: |
Tue, 30 Mar 2010 21:16:31 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
Hi Stefano,
thanks for the patch.
* Stefano Lattarini wrote on Tue, Mar 30, 2010 at 05:52:21PM CEST:
> * Makefile.am (path-check): To be safe, do not use `chmod -R' on
> $(distdir) before removing it (as Solaris `chmod -R' touches
> symlink targets). Instead, use the cleanup strategy used in
> distdir.am (which is also employed in tests/defs.in).
I'm not sure I understand. We are not putting any symlinks into
$(distdir), why would this be needed?
In order for symlinks to end up in $(distdir), you have to have a
dist-hook or similar rule, because normal distributed symlinks in the
source tree will be expanded as regular files in $(distdir).
Thanks,
Ralf
[PATCH 2/2] Avoid an unportable use of `$status' shell variable., Stefano Lattarini, 2010/03/30
Re: A couple of patches w.r.t. the target `path-check', Ralf Wildenhues, 2010/03/30