[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer aroun
From: |
Ralf Wildenhues |
Subject: |
Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests. |
Date: |
Sun, 4 Apr 2010 08:44:05 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
* Stefano Lattarini wrote on Wed, Mar 31, 2010 at 02:11:16PM CEST:
> > Generated tests are now just a thin layer around other tests.
> >
> > * tests/Makefile.am: Rewrite the rule to generate the `*-p.test'
> > test scripts so that any of them simply includes the corresponding
> > `*.test' script (after setting `$parallel_tests' to `yes').
> > * tests/.gitignore: Add wildcard for temporary files used in the
> > generation of `*-p.test' tests.
> >
> > -*-*-
> Sorry if I ping this trivial patch, but it seems simple enough to be
> applied easily if it's deemed worth, and if it's not deemed woth I'd
> like to understand why.
Sorry for dropping the ball on this patch. Some make implementations
detect '#' as starting a comment even in the middle of a variable (Posix
warns about this), but I can't find an offending make now which does so
when the '#' is within a command. Posix doesn't seem clear to me on
this issue however. Oh well, I guess I'll take the patch.
And yes, pinging patches is certainly fine.
Thanks,
Ralf
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.,
Ralf Wildenhues <=