[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] Some cleanup and cosmetic changes in confsub.test.
From: |
Stefano Lattarini |
Subject: |
[PATCH 2/2] Some cleanup and cosmetic changes in confsub.test. |
Date: |
Fri, 9 Apr 2010 19:04:32 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; ) |
And a couple of cosmetic edits to the same test, since I was at it.
Regards,
Stefano
---
Some cleanup and cosmetic changes in confsub.test.
* tests/confsub.test: Prefer `echo' over `cat' to create one-line
data files, and prefer `:' over `cat' to create empty data files.
From d08e93d8d03fcd21cd2e9c56ae6a84a4fd914c33 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Fri, 9 Apr 2010 18:43:22 +0200
Subject: [PATCH 2/2] Some cleanup and cosmetic changes in confsub.test.
* tests/confsub.test: Prefer `echo' over `cat' to create one-line
data files, and prefer `:' over `cat' to create empty data files.
---
ChangeLog | 4 ++++
tests/confsub.test | 7 ++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index c23ac81..26448b5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2010-04-09 Stefano Lattarini <address@hidden>
+ Some cleanup and cosmetic changes in confsub.test.
+ * tests/confsub.test: Prefer `echo' over `cat' to create one-line
+ data files, and prefer `:' over `cat' to create empty data files.
+
Use `set -e' in confsub.test (avoids possible false negatives).
* tests/confsub.test: Enable shell `errexit' flag, and related
changes (this helps avoiding some possible minor false negatives).
diff --git a/tests/confsub.test b/tests/confsub.test
index c96dc84..65221f1 100755
--- a/tests/confsub.test
+++ b/tests/confsub.test
@@ -29,13 +29,10 @@ AM_CONFIG_HEADER(subdir/config.h:subdir/config.hin)
AC_OUTPUT(Makefile subdir/Makefile)
END
-cat > Makefile.am << 'END'
-SUBDIRS = subdir
-END
+echo 'SUBDIRS = subdir' > Makefile.am
mkdir subdir
-cat > subdir/Makefile.am << 'END'
-END
+: > subdir/Makefile.am
echo 'Before.' > subdir/config.hin
--
1.6.5