Re: [PATCH] Avoid possible false negatives in cond46.test.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sun, Apr 11, 2010 at 09:04:55PM CEST:
> At Sunday 11 April 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Fri, Apr 09, 2010 at 02:19:32AM CEST:
> > > Avoid possible false negatives in cond46.test.
> > >
> > > * tests/cond46.test: Enable shell `errexit' flag (and bumped
> > > copyright years).  Due to this change, the testcase should now
> > > fail on unexpected failures in calls to $ACLOCAL/$AUTOMAKE (whose
> > > outcomes were previously unchecked), and on failures in grepping
> > > the expected diagnostic in Automake stderr.
> > 
> > Thanks, applied to maint.  Please let's not get overly verbose in
> >  the log entry.
> > 
> How'd you suggest to shorten the log entry above, while keeping it 
> meaningful?

By cutting the part which I did not quote.  :-)

Being verbose is fine for things that are unobvious, but you may assume
that developers know autoconf.info.

> However, if you think that high terseness is better than high
> verbosity, I could aim for the former when in doubt.

Not in general, but ChangeLog normally document what changed; why
something changed should usually be done in the actual code, if that is
necessary.  I sometimes add short rationale explanations to the log if
the change is otherwise not easily understood.  For this particular
patch, however, no explanation is necessary, because it is self-evident
when looking at the file that changed.

Anyway, this isn't all that crucial one way or the other.

Cheers,
Ralf