Re: [PATCH 5/5] Improved test silent5.test.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:13:11PM CEST:
> At Sunday 25 April 2010, Ralf Wildenhues wrote:
> > Indeed.  Grepping for '^mv ' and ' mv ' should work though.
> Or better again, we could strip off the `Entering/Leaving directory' 
> lines outputted by GNU make.  WDYT?

Other makes have the tendency to print other unrelated stuff.

> > > > > +  # Ensure a clean reconfiguration/rebuild.
> > > > >    $MAKE clean
> > > > >    $MAKE maintainer-clean
> > > > > +  rm -f foo5.c foo6.[ch] sub/baz5.c sub/baz6.[ch]
> > > >
> > > > Wait, maintainer-clean should have removed all these files at
> > > > this point (and some of the other lex/yacc tests should have
> > > > this tested, too).  Does that not work for you?
> > >
> > > No, it works just fine; but in the (unlikely) case of a failure,
> > > it could cause false positives (or even false negatives!) in
> > > silent5.test.
> > 
> > Well, but failure in case of a bug is a good thing, even if it is
> > drive-by failure.  At least for semantics that are known to work.
> OK, then I'll turn that `rm -f' into sanity checks with `test ! -f'.

Why?  This is tested for in another test, and you didn't seem to think
before that it would be broken at the end of the loop.  That's not
logical.

Oh well, not a big deal either way.

Cheers,
Ralf