Re: [PATCH] Extend tests on `nostdinc' automake option.

[Ralf Wildenhues]

Hello Stefano,

* Stefano Lattarini wrote on Mon, Apr 26, 2010 at 02:05:19PM CEST:
> Extend tests on `nostdinc' automake option.
> 
> * tests/nostdinc.test: Make the grepping of the generated
> Makefile.in slighty stricter.  Enable `errexit' shell flag.
> Related and unrelated minor changes.
> Also, updated copyright years.
> * tests/nostdinc2.test: New test.
> * tests/Makefile.am (TESTS): Extended accordingly.

> @@ -18,9 +18,9 @@
>  
>  . ./defs || Exit 1
>  
> -cat >> configure.in << 'END'
> -AC_PROG_CC
> -END
> +set -e
> +
> +echo AC_PROG_CC >> configure.in

In the future, please don't change these kinds of things gratuitously.
Same rationale as trailing ':': using a here-document allows
straight-forward way to extend the text later.

Also, there is generally no need to mention updated copyright years in
the ChangeLog entry unless that is the only change you do (e.g., because
it was forgotten).  This kind of change is expected.  Same reason we
don't mention regenerated Makefile.in files.  Note some other FSF
projects do this differently (notably GCC and binutils).

Since with your patch, nostdinc.test is a strict subset of
nostdinc2.test, why not merge nostdinc2.test into nostdinc.test?  Our
testsuite is slow as it is already.

Thanks for all your work on the testsuite,
Ralf