automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pr-msvc-support merge


From: Peter Rosin
Subject: Re: pr-msvc-support merge
Date: Mon, 21 Jun 2010 12:33:44 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5

Hi Chuck,

Den 2010-06-19 22:09 skrev Charles Wilson:
func_path_conv() assumes that you ALWAYS want to convert from "something
unixish" to win32.  If that's the case -- e.g. it appears to only ever
be called from inside func_cl_wrapper, for which that would always be
true -- then it needs to be documented better.  The current comment:

# Convert a $build path to $host form and store it in $path

doesn't specify that it only works when $host is win32ish.

So, what stops someone from adding the missing conversion when it
is needed, thus fulfilling the promise implied by the name of the
function?

Cheers,
Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]