Re: [PATCH] test defs: add subroutine for input unindenting

[Ralf Wildenhues]

Hello,

* Stefano Lattarini wrote on Mon, Feb 28, 2011 at 01:54:20PM CET:
> On Monday 28 February 2011, Peter Rosin wrote:
> > How about this?
> > 
> > Should the sed command to strip comments be "s/ *#.*//",
> >
> IMHO yes, but I have no strong feelings here -- I'm ok also with the
> "weaker" 's/ #.*//'.

It would be nice your sed script would allow sed scripts like
  s/#//
  s/ #//

to continue to work.  But if they don't, for now, that's not a big
problem either: failures will be noisy.

> > or does that fall into this bucket:
> > 
> >     Unicos 9 sed loops endlessly on patterns like ‘.*\n.*’. 
> >
> I dont see why; there's not `\n' nor repated `.*' in the regex ` *#.*'.

I wouldn't bother with Unicos.  No use outside a museum.

> Your new implementation keeps the test `self-check-unindent.test'
> satisfied, so feel free to push it (either with or without the
> amendment to the 's/ #*.//' expression).

Thanks,
Ralf