[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {master} coverage: add tests on remake rules in more complex
From: |
Bruno Haible |
Subject: |
Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations (was: Re: not breaking "make" after m4 macros and source files changed) |
Date: |
Thu, 7 Apr 2011 02:05:47 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Stefano,
> Done in the attached patch.
Great! I'm glad that you could use my input, although I mostly don't know about
the usual habits and idioms for automake unit tests.
Comments:
- In remake-renamed-m4-macro.test you use "$MAKE test" once and then
"$MAKE check" (twice). Is this intentional? Isn't the 'check' target void?
"$MAKE test" would verify that in the regenerated Makefile, $(the_answer)
still has the same value.
- In remake-gnulib-add-acsubst.test you avoid the "$MAKE Makefile" when using
GNU make:
$using_gmake || $MAKE Makefile
Would it be possible to use this idiom also in the other remake-*-m4-* tests?
- In remake-gnulib-add-header.test: s/speel/sleep/
Otherwise, very nicely done! Thank you!!
Bruno
--
In memoriam The children of Izieu <http://fr.wikipedia.org/wiki/Enfants_d'Izieu>