Re: [PATCH] {yacc-work} tests: do not uselessly require GNU make or gcc in a few tests

[Stefano Lattarini]

On Monday 11 April 2011, Stefano Lattarini wrote:
> Some minor improvements for a few Yacc/Lex tests, helping to drop
> unnecessary requirements.  I have a similar patch for `yacc6.test'
> (which is untouched by the present patch), but that entails heavier
> and potentially more controversial changes, so that I'll present it
> in a seprate thread.
> 
> I think I've tested the patch quite thoroughly with NetBSD and
> FreeBSD make (Debian ports), GNU make and Heirloom make, and
> with the Sun C compiler, pcc and gcc.
> 
> OK for yacc-work?  I will push in 72 hours if there is no objection.
> 
> Regards,
>   Stefano
> 
> -*-*-
> 
> tests: do not uselessly require GNU make or gcc in a few tests
> 
> * tests/lex3.test: Remove gcc from requirements, as any working C
> compiler should be ok.  Consequently, do not clobber user CFLAGS.
> Also, remove GNUmake from requirements; it was added (see commit
> `Release-1-8-103-g0d2f592') because this test fails with FreeBSD
> make due to VPATH issues -- but so do many other yacc-related and
> lex-related tests currently, and requiring GNU make in all of
> them would unacceptably reduce coverage.
> * tests/lexvpath.test: Remove gcc from requirements, as any
> working C compiler should be ok.
> * tests/yacc4.test: Likewise.
> * tests/yacc8.test: Likewise.
> * tests/lex5.test: Likewise.  Also, do not require anymore GNU
> make; to compensate, explicitly call "$MAKE Makefile" to update
> the out-of-date Makefile if $MAKE is not GNU make.
> ---
>  ChangeLog           |   18 ++++++++++++++++++
>  tests/lex3.test     |    6 +-----
>  tests/lex5.test     |    3 ++-
>  tests/lexvpath.test |    2 +-
>  tests/yacc4.test    |    6 +++---
>  tests/yacc8.test    |    2 +-
>  6 files changed, 26 insertions(+), 11 deletions(-)
> 

I've pushed this patch now.

Regards,
  Stefano