automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing


From: Stefano Lattarini
Subject: Re: [PATCH] {maint} tests: new subroutines for test skipping/failing
Date: Sun, 17 Apr 2011 15:27:17 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

Reference:
  <http://lists.gnu.org/archive/html/automake-patches/2011-03/msg00052.html>

On Wednesday 30 March 2011, Stefano Lattarini wrote:
> On Monday 14 March 2011, Stefano Lattarini wrote:
> > Hello Ralf and all automakers.
> > 
> > Reference:
> >  <http://lists.gnu.org/archive/html/automake-patches/2011-01/msg00296.html>
> > Whole original thread:
> >  <http://lists.gnu.org/archive/html/automake-patches/2011-01/msg00192.html>
> > which stemmed from:
> >  <http://lists.gnu.org/archive/html/automake-patches/2011-01/msg00144.html>
> > 
> > > > Well, what I was trying to say is: what use is TESTS_SETUP if we expand
> > > > to
> > > >   $(AM_TESTS_SETUP) $(TESTS_SETUP) $(TESTS_ENVIRONMENT)
> > > > 
> > > > ?  It can simply be merged into TESTS_ENVIRONMENT; there is no point in
> > > > keeping them separate.
> > > > 
> > > > And then, we can rename AM_TESTS_SETUP to AM_TESTS_ENVIRONMENT if we
> > > > like, or not (consistency vs. green bikeshed question).
> > > > 
> > > > I'll leave it up to the person who writes the documentation with
> > > > detailed explanation of intended semantics.
> > > > 
> > > Attached is my attempt (I'm not sure the new documentation is organized
> > > in the best possible way, though).  Tested with "make html pdf".
> > > 
> > > BTW, should this patch (or an amndned version of it) go into maint or
> > > into master?
> > > 
> > > Thanks,
> > >    Stefano
> > > 
> > A friendly ping on this?
> > 
> > The failure to apply this patch is blocking the planned increase
> > of code sharing between gnulib's `tests/init.sh' and automake's
> > `tests/defs', which in turn is blocking the possibility to define
> > and use proper subroutines for test skipping/failing -- which in
> > turn is blocking the improvement/addition of more detailed, clear
> > explanations for test skips.
> > 
> > Regards,
> >   Stefano
> > 
> Ping^2?
> 
> I'll push in 72 hours if there are no further objections.
> 
> Regards,
>   Stefano
> 

I've applied the patch to a temporary branch off of maint, merged to
master, and pushed.

Regards,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]