[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docs: Add references between the 2 sections on compiling Jav
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] docs: Add references between the 2 sections on compiling Java. |
Date: |
Sun, 17 Jul 2011 10:43:32 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Sunday 17 July 2011, tsuna wrote:
> On Sat, Jul 16, 2011 at 6:18 AM, Stefano Lattarini
> <address@hidden> wrote:
> > diff --git a/doc/automake.texi b/doc/automake.texi
> > index 9024888..e186489 100644
> > --- a/doc/automake.texi
> > +++ b/doc/automake.texi
> > @@ -6666,8 +6666,9 @@ is as follows:
> > @cindex Support for Java
> >
> > Automake includes support for natively compiled Java, using @command{gcj},
> > -the Java front end to the GNU Compiler Collection, as well as some
> > preliminary
> > -support for compiling Java to bytecode (see @pxref{Java}).
> > +the Java front end to the GNU Compiler Collection (preliminary support
> > +for compiling Java to bytecode using the @command{javac} compiler is
> > +also present; @pxref{Java}).
>
> Wouldn't it be better to have "See @pxref{Java}" than just a link to "Java"?
But "@pxref" prepends "see" to the link automatically:
<http://www.cims.nyu.edu/cgi-comment/info2html?(texinfo)pxref>
So using "see @pexref{...}" is, in fact, incorrect.
> > Any package including Java code to be compiled must define the output
> > variable @code{GCJ} in @file{configure.ac}; the variable @code{GCJFLAGS}
> > @@ -7535,9 +7536,9 @@ libtool, The Libtool Manual}) with the
> > @code{LTLIBRARIES} primary.
> > @cindex @code{JAVA} primary, defined
> > @cindex Primary variable, @code{JAVA}
> >
> > -Automake provides some minimal support for Java compilation with the
> > address@hidden primary, as well as support for compiling Java to native
> > -machine code (see @pxref{Java Support}).
> > +Automake provides some minimal support for Java bytecode compilation with
> > +the @code{JAVA} primary (in addition to the support for compiling Java to
> > +native machine code; @pxref{Java Support}).
>
> Ditto.
>
Likewise.
> > The amended patch is attached. I'll wait until tomorrow for objections
> > before pushing it (to maint).
>
> Either way, your changes are fine by me. Thank you.
>
Good. Before pushing, I'll give Ralf some more time to chime in (until this
evening at least).
Thanks,
Stefano