automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {GSoC} testsuite: fix spurious errors in an xfailing test on TAP s


From: Stefano Lattarini
Subject: [FYI] {GSoC} testsuite: fix spurious errors in an xfailing test on TAP support
Date: Tue, 2 Aug 2011 00:16:57 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

* tests/plan-bad-prog.test: Fix typo in the name of the test
being made unreadable.  Correct the wording of the potential
skip message, and simplify the condition under which the test
is to be skipped.  Escape literal dots in grep regexps.
---
 ChangeLog               |    8 ++++++++
 tests/tap-bad-prog.test |   12 +++++-------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b6199f3..655602b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2011-08-01  Stefano Lattarini  <address@hidden>
 
+       testsuite: fix spurious errors in an xfailing test on TAP support
+       * tests/plan-bad-prog.test: Fix typo in the name of the test
+       being made unreadable.  Correct the wording of the potential
+       skip message, and simplify the condition under which the test
+       is to be skipped.  Escape literal dots in grep regexps.
+
+2011-08-01  Stefano Lattarini  <address@hidden>
+
        testsuite: better granularity in a couple of tests on TAP support
        * tests/tap-summary-aux.sh: New auxiliary script, filled with code
        moved out from ...
diff --git a/tests/tap-bad-prog.test b/tests/tap-bad-prog.test
index af54b2e..e20009d 100755
--- a/tests/tap-bad-prog.test
+++ b/tests/tap-bad-prog.test
@@ -44,11 +44,9 @@ END
 ./noexec.test && skip_ "can't have non-executable files"
 
 cp noexec.test noread.test
-chmod a-r noread
+chmod a-r noread.test
 
-if test -r noread.test || cat noread.test; then
-  skip_ "can't have readonly files"
-fi
+test -r noread.test && skip_ "you can still read unreadable files"
 
 $ACLOCAL
 $AUTOCONF
@@ -60,9 +58,9 @@ $MAKE check >stdout && { cat stdout; Exit 1; }
 cat stdout
 
 # FIXME: maybe better error messages?
-grep '^ERROR: none.test' stdout
-grep '^ERROR: noexec.test' stdout
-grep '^ERROR: noread.test' stdout
+grep '^ERROR: none\.test' stdout
+grep '^ERROR: noexec\.test' stdout
+grep '^ERROR: noread\.test' stdout
 
 count_test_results total=3 pass=0 fail=0 xpass=0 xfail=0 skip=0 error=3
 
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]