[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [FYI] {test-protocols} maintcheck: fix more maintainer-check failure
From: |
Stefano Lattarini |
Subject: |
Re: [FYI] {test-protocols} maintcheck: fix more maintainer-check failures |
Date: |
Wed, 3 Aug 2011 18:04:08 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Wednesday 03 August 2011, Stefano Lattarini wrote:
> * tests/test-driver-custom-no-html.test (no-rst): Use `EOF',
> not `EoL', as the here-document delimiter.
> * tests/test-trs-basic.test: Use `cat + here-doc' rather
> than `echo' when creating the dummy test scripts, to please
> maintainer-check.
> * tests/test-trs-recover.test: Use creative quoting where
> needed, to please maintainer-check.
> * tests/parallel-tests-no-color-in-log.test: Likewise.
> * tests/parallel-tests-dry-run.test: Likewise.
>
And consider this squashed-in:
diff --git a/tests/parallel-tests-dry-run.test
b/tests/parallel-tests-dry-run.test
index 92a5c51..888d888 100755
--- a/tests/parallel-tests-dry-run.test
+++ b/tests/parallel-tests-dry-run.test
@@ -72,8 +72,12 @@ test -f foo.trs
test -f foo.log
test -f bar.trs
-echo 'echo this is bad; exit 1' > foo.test
-echo 'exit 0' > bar.test
+# FIXME: creative quoting below to please maintainer-check.
+cat > foo.test <<END
+echo this is bad
+exit 1
+END
+echo exit '0' > bar.test
for target in check recheck test-suite.log; do
make_n_ $target
Sorry for the noise,
Stefano