automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] testsuite: fix an unportable use of sed


From: Stefano Lattarini
Subject: [PATCH] testsuite: fix an unportable use of sed
Date: Sat, 13 Aug 2011 10:30:54 +0200

* tests/tap-todo-skip-whitespace.test: Alternation with "\|" in
sed regular expressions is not portable to (at least) FreeBSD
sed; do not use it.
---
 ChangeLog                           |    7 +++++++
 tests/tap-todo-skip-whitespace.test |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 98ce73e..bf629e1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2011-08-12  Stefano Lattarini  <address@hidden>
 
+       testsuite: fix an unportable use of sed
+       * tests/tap-todo-skip-whitespace.test: Alternation with "\|" in
+       sed regular expressions is not portable to (at least) FreeBSD
+       sed; do not use it.
+
+2011-08-12  Stefano Lattarini  <address@hidden>
+
        testsuite: avoid spurious failure if rst2html program is missing
        * tests/test-driver-custom-no-html.test: Account for the
        possibility of a lacking `rst2html' program in our final
diff --git a/tests/tap-todo-skip-whitespace.test 
b/tests/tap-todo-skip-whitespace.test
index 695e98c..fe32c97 100755
--- a/tests/tap-todo-skip-whitespace.test
+++ b/tests/tap-todo-skip-whitespace.test
@@ -76,7 +76,7 @@ my_make_check ()
   # Don't be too strict w.r.t. possible normalization of "TODO: foo" into
   # "TODO : foo" (as is done by, e.g., the 'TAP::Parser' perl module).
   LC_ALL=C grep '^[A-Z][A-Z]*:' stdout \
-    | sed -e 's/# \(TODO\|SKIP\) *:/# \1:/' > got
+    | sed -e 's/# TODO *:/# TODO:/' -e 's/# SKIP *:/# SKIP:/' > got
   cat exp
   cat got
   diff exp got
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]