[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[FYI 4/6] {testsuite-work} testsuite: avoid confusing SKIP messages for
From: |
Stefano Lattarini |
Subject: |
[FYI 4/6] {testsuite-work} testsuite: avoid confusing SKIP messages for errored tests |
Date: |
Sun, 14 Aug 2011 16:37:56 +0200 |
* tests/defs [$use_tap] (exit trap): Don't print the test plan
in case the client script exited with a non-zero status. This
avoids the display of redundant "SKIP" messages for tests with
lazy plans that error out before any test is run.
---
ChangeLog | 8 ++++++++
tests/defs | 2 +-
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0551327..8a009a7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-08-14 Stefano Lattarini <address@hidden>
+
+ testsuite: avoid confusing SKIP messages for errored tests
+ * tests/defs [$use_tap] (exit trap): Don't print the test plan
+ in case the client script exited with a non-zero status. This
+ avoids the display of redundant "SKIP" messages for tests with
+ lazy plans that error out before any test is run.
+
2011-08-13 Stefano Lattarini <address@hidden>
testsuite: keep more debugging info around in 'add-missing.tap'
diff --git a/tests/defs b/tests/defs
index 3bd378e..6f9c518 100644
--- a/tests/defs
+++ b/tests/defs
@@ -868,7 +868,7 @@ if test "$sh_errexit_works" = yes; then
keep_testdirs=no
fi
if test $using_tap = yes; then
- if test $have_tap_plan_ != yes; then
+ if test $have_tap_plan_ != yes && test $exit_status -eq 0; then
plan_ "now"
fi
test $exit_status -eq 0 && test $tap_pass_count_ -eq $tap_count_ \
--
1.7.2.3
- [FYI 0/6] {testsuite-work} More testsuite patches, Stefano Lattarini, 2011/08/14
- [FYI 1/6] {testsuite-work} testsuite: fixlets and improvements in two long TAP-based tests, Stefano Lattarini, 2011/08/14
- [FYI 2/6] {testsuite-work} testsuite: more granular count of test results in our TAP library, Stefano Lattarini, 2011/08/14
- [FYI 3/6] {testsuite-work} testsuite: keep more debugging info around in 'add-missing.tap', Stefano Lattarini, 2011/08/14
- [FYI 4/6] {testsuite-work} testsuite: avoid confusing SKIP messages for errored tests,
Stefano Lattarini <=
- [FYI 5/6] {testsuite-work} maintcheck: look for TAP-based tests without TAP plan, Stefano Lattarini, 2011/08/14
- [FYI 6/6] {testsuite-work} self tests: some minor refactoring, Stefano Lattarini, 2011/08/14